RANGER-5351:Test Cases for agents-cred [ranger-plugins-cred] Module #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaveshamre
force-pushed
the
bh-RANGER-5351
branch
from
8b83602 to
fdc6a35
Compare
dhavalshah9131
requested review from
dineshkumar-yadav,
kishorgollapalliwar,
kumaab,
mneethiraj and
pradeepagrawal8184
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the agents-cred module, improving Jacoco coverage from 12% to 86%. The changes introduce test classes for credential provider utilities and Kerberos authentication components using both JUnit 4 and JUnit 5 frameworks.
- Added unit tests for
RangerCredentialProvider,KeytabJaasConf,KerberosCredentialsProvider, andCredentialsProviderUtil - Introduced Mockito dependencies for enhanced testing capabilities
- Mixed JUnit 4 and JUnit 5 usage across different test classes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| RangerCredentialProviderTest.java | Added singleton test and migrated from JUnit 4 to JUnit 5 assertions while retaining JUnit 4 annotations |
| KeytabJaasConfTest.java | New test class for Kerberos JAAS configuration with JUnit 5 |
| KerberosCredentialsProviderTest.java | New test class for Kerberos credentials provider with JUnit 5 |
| CredentialsProviderUtilTest.java | Comprehensive test class for credential utilities with extensive mocking |
| pom.xml | Added Mockito dependencies for testing framework support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java
Show resolved
Hide resolved
...src/test/java/org/apache/ranger/authorization/hadoop/utils/RangerCredentialProviderTest.java
Show resolved
Hide resolved
...red/src/test/java/org/apache/ranger/authorization/credutils/CredentialsProviderUtilTest.java
Outdated
Show resolved
Hide resolved
…utils/CredentialsProviderUtilTest.java Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Disclosure
Added AI-generated Test methods/Test classes using Cursor AI for module agents-cred [ranger-plugins-cred] and manually reviewed.
What changes were proposed in this pull request?
RANGER-5351: agents-cred [ranger-plugins-cred] Module
How was this patch tested?
Build successful along with test cases.
As per Jacoco
Apache -> agents-cred [ranger-plugins-cred] Module
Improved Jacoco coverage across multiple packages:
agents-cred [ranger-plugins-cred] module: 12% → 86%